Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(smoke): scenario where root user installing Snyk #1502

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

JackuB
Copy link
Contributor

@JackuB JackuB commented Nov 3, 2020

This PR introduces:

New docker container for Smoke Tests, that runs CLI install as root, replicating the issue from https://github.com/snyk/snyk/issues/1453

Screenshot 2020-11-03 at 17 16 49

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2020

Warnings
⚠️

Looks like you added a new Tap test. Consider making it a Jest test instead. See files like test/*.spec.ts for examples. Files found:

  • test/smoke/docker-root/Dockerfile
  • test/smoke/docker-root/entrypoint.sh
Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against c095596

@JackuB JackuB force-pushed the smoke/docker-root branch 8 times, most recently from 4b6e6a6 to b344c8b Compare November 3, 2020 15:40
@JackuB JackuB marked this pull request as ready for review November 3, 2020 16:18
@JackuB JackuB requested review from a team as code owners November 3, 2020 16:18
@ghost ghost requested review from gitphill and orsagie November 3, 2020 16:18
Copy link
Contributor

@Avishagp Avishagp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@JackuB JackuB merged commit 32f23aa into master Nov 4, 2020
@JackuB JackuB deleted the smoke/docker-root branch November 4, 2020 13:47
@snyksec
Copy link

snyksec commented Nov 4, 2020

🎉 This PR is included in version 1.424.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants