fix: support globs pattern in yarn workspaces definitions #1507
+47
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
lili2311
force-pushed
the
fix/support-globs-pattern-yarn-workspaces
branch
2 times, most recently
from
0b6d590
to
32699fe
Compare
lili2311
force-pushed
the
fix/support-globs-pattern-yarn-workspaces
branch
from
32699fe
to
5554acf
Compare
lili2311
commented
Nov 3, 2020
| @@ -1,7 +1,8 @@ | |||
| { | |||
| "private": true, | |||
| "workspaces": [ | |||
| "packages/*" | |||
| "packages/*", | |||
| "libs/**/*" | |||
There was a problem hiding this comment.
globs pattern here!
ekbsnyk
approved these changes
Nov 3, 2020
|
🎉 This PR is included in version 1.424.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Yarn workspaces patterns also support globs pattern, update the matching to cover this too.
Also added a failing test to show a deep globs pattern in workspaces definitions was not supported until the fix