fix: remove spec requirement #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
almog27
approved these changes
Nov 5, 2020
p0tr3c
force-pushed
the
fix/k8s-object-requirements
branch
from
b6f9946
to
3152782
Compare
p0tr3c
force-pushed
the
fix/k8s-object-requirements
branch
from
3152782
to
bb7efaf
Compare
|
🎉 This PR is included in version 1.424.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the requirement of
specto accept yaml files as valid k8s objectsWhere should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
We currently reject yaml files if the
specfield is not present in k8s object.This is not valid requirement for all k8s object for example service-account
What are the relevant tickets?
Zendesk
Screenshots
Additional questions