Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gradle 5.4 Java 11 Dockerfile npm install #1596

Merged
merged 1 commit into from Jan 28, 2021

Conversation

gitphill
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

When building docker image we see error message:

The following packages have unmet dependencies:
 nodejs : Conflicts: npm
 npm : Depends: node-gyp (>= 3.6.2~) but it is not going to be installed
E: Unable to correct problems, you have held broken packages.

Removing explicit npm install from 'apt-get install' fixes issue.

Just doing 'apt-get install -y nodejs' will install npm.

When building docker image we see error message:

The following packages have unmet dependencies:
 nodejs : Conflicts: npm
 npm : Depends: node-gyp (>= 3.6.2~) but it is not going to be installed
E: Unable to correct problems, you have held broken packages.

Removing explicit npm install from 'apt-get install' fixes issue.

Just doing 'apt-get install -y nodejs' will install npm.
@gitphill gitphill requested review from a team as code owners January 28, 2021 14:30
@gitphill gitphill self-assigned this Jan 28, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2021

Expected release notes (by @gitphill)

fixes:
gradle 5.4 Java 11 Dockerfile npm install (50d34c0)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@gitphill gitphill merged commit 3f4a57e into master Jan 28, 2021
@gitphill gitphill deleted the fix/gradle-54-java11-dockerfile branch January 28, 2021 15:52
@snyksec
Copy link

snyksec commented Jan 28, 2021

🎉 This PR is included in version 1.440.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants