Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update critical sev colour #1627

Merged
merged 3 commits into from Feb 17, 2021
Merged

feat: update critical sev colour #1627

merged 3 commits into from Feb 17, 2021

Conversation

karenyavine
Copy link
Member

@karenyavine karenyavine commented Feb 10, 2021 •
edited

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

  • Adds colors for future support for critical severity
  • Adds default fallback color for unknown severities
  • Single place for color definitions

@karenyavine karenyavine self-assigned this Feb 10, 2021
@karenyavine karenyavine requested a review from a team as a code owner February 10, 2021 12:56
@karenyavine karenyavine requested a review from a team February 10, 2021 12:56
@karenyavine karenyavine requested a review from a team as a code owner February 10, 2021 12:56
aron
aron approved these changes Feb 11, 2021
View reviewed changes
src/cli/commands/test/iac-output.ts Outdated Show resolved Hide resolved
karenyavine
karenyavine commented Feb 15, 2021
View reviewed changes
src/lib/snyk-test/common.ts
@@ -24,6 +25,7 @@ export enum SEVERITY {
LOW = 'low',
MEDIUM = 'medium',
HIGH = 'high',
CRITICAL = 'critical',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JackuB Any reason we have severities enum defined twice? once here and once in src/lib/snyk-test/legacy.ts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think it's intended

JackuB
JackuB suggested changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@JackuB JackuB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be documented in the CLI help?

Left some minor questions before approving

src/lib/snyk-test/common.ts
@@ -24,6 +25,7 @@ export enum SEVERITY {
LOW = 'low',
MEDIUM = 'medium',
HIGH = 'high',
CRITICAL = 'critical',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think it's intended

src/lib/snyk-test/common.ts Outdated Show resolved Hide resolved
src/cli/commands/test/iac-output.ts Show resolved Hide resolved
@karenyavine karenyavine force-pushed the chore/update-critical-sev-colour branch 2 times, most recently from 5215d82 to d7c6353 Compare February 16, 2021 13:49
@karenyavine
chore: unified place for severity-to-color mapping
ea94dea 
chore: add default color for unknown severity and avoid crashing
test: update testing to include critical severity
@karenyavine
chore: export function to map severity to color
96f619e
@karenyavine karenyavine force-pushed the chore/update-critical-sev-colour branch from d7c6353 to 96f619e Compare February 16, 2021 14:36
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2021 •
edited by karenyavine

Expected release notes (by @karenyavine)

features:
adds support for critical severity (cc8730e)

others (will not be included in Semantic-Release notes):
export function to map severity to color (96f619e)
unified place for severity-to-color mapping (ea94dea)
CLA update (296d73e)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@karenyavine karenyavine changed the title chore: update critical sev colour feat: update critical sev colour Feb 17, 2021
@karenyavine karenyavine merged commit 787308d into master Feb 17, 2021
@karenyavine karenyavine deleted the chore/update-critical-sev-colour branch February 17, 2021 08:05
@snyk-bot snyk-bot mentioned this pull request Mar 30, 2023
Open
@nathan-snyk nathan-snyk mentioned this pull request Jun 21, 2023
Open
@MaxMood96 MaxMood96 mentioned this pull request Jun 21, 2023
Open
@aliscco aliscco mentioned this pull request Jun 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aron aron aron approved these changes

@JackuB JackuB JackuB approved these changes

@gitphill gitphill Awaiting requested review from gitphill

Assignees

@karenyavine karenyavine

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@karenyavine @aron @JackuB @gitphill @thisislawatts