Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show auto detected user instructions in 'container test' output #1630

Conversation

agatakrajewska
Copy link
Contributor

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Updated 'container test' Dockerfile instructions to "Image layer:" to be consistent with what we show in the UI.
Added showing auto detected instructions if Dockerfile not present.

Where should the reviewer start?

What are the relevant tickets?

https://snyksec.atlassian.net/browse/CAP-149

container test json output

✗ Low severity vulnerability found in bzip2/libbz2-1.0
  Description: Denial of Service (DoS)
  Info: http://localhost:12346/vuln/SNYK-LINUX-BZIP2-106947
  Introduced through: bzip2/libbz2-1.0@1.0.6-8.1, apt/libapt-pkg5.0@1.6.3ubuntu0.1
  From: bzip2/libbz2-1.0@1.0.6-8.1
  From: apt/libapt-pkg5.0@1.6.3ubuntu0.1 > bzip2/libbz2-1.0@1.0.6-8.1
  Image layer: 'RUN test instruction'

@agatakrajewska agatakrajewska self-assigned this Feb 11, 2021
@agatakrajewska agatakrajewska requested review from a team as code owners February 11, 2021 10:34
Updated 'container test' Dockerfile instructions to "Image layer:" to be consistent with what we show in the UI.
Added showing auto detected instructions if Dockerfile not present.
@agatakrajewska agatakrajewska force-pushed the feat/CAP-149-auto-detected-user-instructions-in-test-output branch from 17d03ec to 2e3237e Compare February 11, 2021 10:39
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2021

Expected release notes (by @agatakrajewska)

features:
Show auto detected user instructions in 'container test' output (2e3237e)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@agatakrajewska agatakrajewska merged commit 640df3c into master Feb 11, 2021
@agatakrajewska agatakrajewska deleted the feat/CAP-149-auto-detected-user-instructions-in-test-output branch February 11, 2021 11:16
@agatakrajewska
Copy link
Contributor Author

Thank you @gitphill !! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants