feat: Don't open browser auth if inside container #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hisenb3rg
force-pushed
the
feat/docker-auth
branch
from
8a8e27d
to
5a35720
Compare
hisenb3rg
force-pushed
the
feat/docker-auth
branch
from
5a35720
to
2c6d5ab
Compare
JackuB
approved these changes
Feb 18, 2021
| @@ -25,7 +26,7 @@ const debug = Debug('snyk-auth'); | |||
| let attemptsLeft = 0; | |||
|
|
|||
| function resetAttempts() { | |||
| attemptsLeft = 30; | |||
| attemptsLeft = isDocker() ? 60 : 30; | |||
hisenb3rg
force-pushed
the
feat/docker-auth
branch
from
2c6d5ab
to
cfda42e
Compare
Allow running auth command when inside a docker container by: * not trying to open a browser via xdg open (breaks if not present) * providing a better auth prompt/message * doubling the auth timeout period, so users have more time open browser manually
hisenb3rg
force-pushed
the
feat/docker-auth
branch
from
cfda42e
to
da53738
Compare
This was referenced Apr 27, 2023
This was referenced Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows running auth command when inside a docker container by:
manually
This makes it possible to use auth command via "docker scan" on soon to be released scan plugin for docker linux.
How should this be manually tested?
Run "snyk auth" inside a container.
What are the relevant tickets?
https://snyksec.atlassian.net/browse/DC-1077