feat: execute all tests with lerna to test all packages #1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lili2311
force-pushed
the
chore/run-tests-with-lerna
branch
2 times, most recently
from
1781ed0
to
58bf4b9
Compare
JackuB
reviewed
Feb 18, 2021
lili2311
force-pushed
the
chore/run-tests-with-lerna
branch
2 times, most recently
from
5be46dc
to
80b0149
Compare
lili2311
commented
Feb 19, 2021
| @@ -227,7 +230,7 @@ jobs: | |||
| command: echo "//registry.npmjs.org/:_authToken=$env:NPM_TOKEN" >> .npmrc | |||
| - run: | |||
| name: Install dependencies (Windows) | |||
| command: npm install --ignore-scripts # ignore-scripts required because of postinstall script in snyk-resolve-deps package | |||
There was a problem hiding this comment.
no longer needed as snyk-resolve-deps postinstall was migrated to prepare
lili2311
force-pushed
the
chore/run-tests-with-lerna
branch
6 times, most recently
from
a643dc5
to
249f5be
Compare
|
@JackuB please 👀 |
lili2311
force-pushed
the
chore/run-tests-with-lerna
branch
2 times, most recently
from
565bf8c
to
2a2cf08
Compare
Lerna can execute all package tests found in the repo https://github.com/lerna/lerna/tree/main/commands/run#readme
lili2311
force-pushed
the
chore/run-tests-with-lerna
branch
from
2a2cf08
to
e7d7a34
Compare
lili2311
commented
Feb 22, 2021
| @@ -128,7 +128,7 @@ describe('Analytics basic testing', () => { | |||
| 'integrationEnvironmentVersion', | |||
| ].sort(), | |||
| ); | |||
| }); | |||
| }, 10000); | |||
There was a problem hiding this comment.
these were super flaky and not completing in a default given time
JackuB
reviewed
Feb 23, 2021
| @@ -241,25 +247,25 @@ jobs: | |||
| steps: | |||
| - run: | |||
| name: Run "Root" tap tests | |||
| command: npm run test:test | |||
| command: lerna run test:test --stream | |||
There was a problem hiding this comment.
So is the plan that each package will have a task called test:test and test:jest? I think it's just a limitation of the current CLI that we have tests split like this.
How about removing the test script from the root package.json (as we can't/don't use it now) and just have a lerna run test that will test packages? We might even have a single container dedicated for that now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Run commands that need to be run on all packages with Lerna, and use
npmfor the rest.Lerna can execute all package tests found in the repo
https://github.com/lerna/lerna/tree/main/commands/run#readme