Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snyk protect prime time #1656

Merged
merged 6 commits into from Mar 1, 2021
Merged

Snyk protect prime time #1656

merged 6 commits into from Mar 1, 2021

Conversation

maxjeffos
Copy link
Contributor

@maxjeffos maxjeffos commented Feb 23, 2021 •
edited

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

  • Modularizes and tests the new Snyk protect package.
  • add testing config so we can test packages

@maxjeffos maxjeffos requested review from a team as code owners February 23, 2021 17:50
@maxjeffos maxjeffos force-pushed the feat/protect-prime-time branch 26 times, most recently from 9659105 to d8a68e3 Compare February 26, 2021 13:38
maxjeffos
maxjeffos commented Feb 26, 2021
View reviewed changes
packages/snyk-protect/package.json Outdated
"build": "tsc"
"build": "tsc",
"test": "npm run test:package",
"test:package": "npm run test:unit && npm run test:acceptance",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

take out test:package and just make test call npm run test:unit && npm run test:acceptance

@maxjeffos maxjeffos force-pushed the feat/protect-prime-time branch 9 times, most recently from a532996 to 87c4ec4 Compare March 1, 2021 17:35
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2021 •
edited by JackuB

Expected release notes (by @maxjeffos)

features:
implement snyk protect (3e7e99e)

others (will not be included in Semantic-Release notes):
fix flakey json output test (69cd590)
run tests in packages in CI (4848b7e)
enable prettier formatting in packages (bb233f1)
enable jest testing in snyk-protect workspace (fe0183d)
test fixture for snyk protect (40ec817)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@maxjeffos maxjeffos merged commit ebb8dd7 into master Mar 1, 2021
@maxjeffos maxjeffos deleted the feat/protect-prime-time branch March 1, 2021 18:22
@JackuB JackuB mentioned this pull request Mar 1, 2021
Merged
3 tasks
This was referenced Apr 26, 2023
Open
Open
Open
Open
This was referenced Apr 28, 2023
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Apr 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackuB JackuB JackuB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@maxjeffos @JackuB