Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial snyk-fix package setup & loadPlugin functionality #1659

Merged
merged 1 commit into from Mar 4, 2021

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Feb 24, 2021

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

  • setup a new snyk-fix workspace for fix package functionality
  • basic loadPlugin functionality & types added
  • a couple of basic tests to ensure loadPlugin is working as expected
  • add Bull (Tech Services) as codeowners

Where should the reviewer start?

Check the package.json & any relevant release setup mostly 馃檹 all the code will change a lot after this initial version and is there mostly to have basic skeleton + tests

How should this be manually tested?

npm run test inside the package

Any background context you want to provide?

Package tests will not trigger until this functionality is added shortly.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2021

Messages
馃摉

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 馃毇 dangerJS against a6b708e

@lili2311 lili2311 force-pushed the feat/initial-snyk-fix-setup branch 5 times, most recently from 4e60b73 to 806289f Compare March 1, 2021 19:34
Copy link
Contributor

@JackuB JackuB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small merge conflict in release-scripts/update-versions.sh

- setup a new snyk-fix workspace for fix package functionality
- basic loadPlugin functionality & types added
- a couple of basic tests to ensure loadPlugin is working as expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants