fix: support package.json missing name property #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitphill
reviewed
Mar 25, 2021
| let dependencies = packageJson.dependencies; | ||
| if (options.dev) { | ||
| dependencies = { ...dependencies, ...packageJson.devDependencies }; | ||
| } | ||
| if (isEmpty(dependencies)) { | ||
| return new Promise((resolve) => | ||
| resolve({ | ||
| name: packageJson.name, | ||
| name: packageJson.name || 'unnamed-package', |
There was a problem hiding this comment.
is this the default name we use elsewhere in Snyk?
could you write a test to assert this fallback behaviour?
aviadhahami
force-pushed
the
fix/unnamed-package-json
branch
from
cb15efe
to
5da3171
Compare
JamesPatrickGill
force-pushed
the
fix/unnamed-package-json
branch
from
5da3171
to
9d31b97
Compare
This is to fix a bug where package.json without name property would throw an error.
JamesPatrickGill
force-pushed
the
fix/unnamed-package-json
branch
from
9d31b97
to
c8738d5
Compare
|
Expected release notes (by @JamesPatrickGill) fixes: others (will not be included in Semantic-Release notes):
|
gitphill
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is to fix a bug where package.json without name property would throw an error.