feat: introduce envvar to control HTTP-HTTPS upgrade behavior #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackuB
force-pushed
the
feat/dont-force-https
branch
from
6e374f7
to
2505b1f
Compare
JackuB
force-pushed
the
feat/dont-force-https
branch
from
2505b1f
to
165b4b9
Compare
maxjeffos
approved these changes
Mar 29, 2021
Co-authored-by: Jeff McLean <44034094+maxjeffos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to the #1771
This PR adds an optional ennvar
SNYK_HTTP_PROTOCOL_UPGRADEto disable the behavior to upgradehttpendpoints tohttps.Fixes the behavior about query strings, that could've lacked the
/?charactersIt also updates Help documentation about
HTTP(S)_PROXYenvvar.