chore: remove redundant lodash.endswith package #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-stehlik
force-pushed
the
chore/remove-lodash-endswith-lib
branch
from
75e6362
to
5678bb3
Compare
1 task
admons
approved these changes
May 5, 2021
jan-stehlik
force-pushed
the
chore/remove-lodash-endswith-lib
branch
from
5678bb3
to
0c3ae68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove redundant lodash.endswith library
Where should the reviewer start?
The change affects only one comand
snyk testthe test scenario is described belowHow should this be manually tested?
snyk test /path/to/any/package/with/known/manifest/file pathB --project-name=ANYExpected output to stderr:
Not a recognised option did you mean --file=/Users/jan/projects/customer-bugs/snyk-poetry-bug/Pipfile? Check other options by running snyk --helpAny background context you want to provide?
As a part of working on other ticket I've noticed that we use
lodash.endswithonly in one place and it can easily be removed.