Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug we had with scanning the full state in a given terraform plan output.
It does it by simplifying the logic and remove extraction logic we don't need any more.
The new mechanism iterates on
resource_changes
for both full & delta scan, but the only difference is that for full scans it also scans resource which hadno-op
action on them, resulting in a full scan of the infrastructure state.This PR also adds a more comprehensive regression test-suite to all various use-cases of scan modes and different terraform plan use-cases (create, delete, update, no-op)
Where should the reviewer start?
See the changes to the terraform parser.
Then see the new regression tests added to cover major use-cases.
https://snyksec.atlassian.net/browse/CC-840