Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: be able to scan huge yarn 2 lockfiles #1897

Merged
merged 1 commit into from May 7, 2021

Conversation

jan-stehlik
Copy link
Contributor

@jan-stehlik jan-stehlik commented May 7, 2021

What does this PR do?

Bumps nodejs parser that fixes parsing huge yarn.lock files managed by yarn 2. More info in snyk/nodejs-lockfile-parser#108

Before:

Screenshot 2021-05-07 at 12 55 10

After:

Screenshot 2021-05-07 at 12 55 20

Manual testing

npm i && npm run build
node dist/cli/index.js test path/to/nodejs-lockfile-parser/test/fixtures/yarn/yarn2/big

Expected result: vulnerabilies are successfully scanned

@jan-stehlik jan-stehlik requested review from a team as code owners May 7, 2021 13:01
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2021

Expected release notes (by @jan-stehlik)

fixes:
be able to scan huge yarn 2 lockfiles (356c329)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@jan-stehlik jan-stehlik merged commit 2895e76 into master May 7, 2021
@jan-stehlik jan-stehlik deleted the fix/fix-parsing-huge-yarn2-lockfiles branch May 7, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants