smoke: get rid of changes from #1974 to fix broken test #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avishagp
force-pushed
the
smoke/fix-broken-smoke-tests
branch
from
352c231
to
217d1fa
Compare
JackuB
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Our smoke tests started failing yesterday in yarn: https://github.com/snyk/snyk/actions/runs/918392114
This happens due to npm trying to grab NPM_TOKEN from the registry instead of from the environment variable, so I got rid of the changes done in this PR: https://github.com/snyk/snyk/pull/1974/files
https://snyk.slack.com/archives/G01AZS8UNUR/p1623182504130200