Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: partition Python projects by fixable earlier on in Snyk fix flow #2016

Merged
merged 2 commits into from
Jun 11, 2021

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Jun 10, 2021

What does this PR do?

  • drop unused error
  • correct error codes
  • partition all items by fixable vs not before the handlers are called instead of repeating it in each

@lili2311 lili2311 self-assigned this Jun 10, 2021
@lili2311 lili2311 force-pushed the fix/partition-by-fixable branch 3 times, most recently from 1e47c03 to 7939773 Compare June 10, 2021 13:09
- Drop unused invalid-workspace.ts file
- Partition Python entities by fixable early on so it is
done once only and not in each handler
- Create and use correct error codes that match the errors
@lili2311 lili2311 changed the title Fix/partition by fixable Fix: partition Python projects by fixable earlier on in Snyk fix flow Jun 10, 2021
The release has no new functionality but some test/release and bumped package versions.
@github-actions
Copy link
Contributor

github-actions bot commented Jun 10, 2021

Expected release notes (by @lili2311)

features:
use latest version of @snyk/fix-pipenv-pipfile package (b0a45f8)

fixes:
partition by fixable before handlers (120f8e4)
upgrade chalk from 4.1.0 to 4.1.1 (84b66a6)

others (will not be included in Semantic-Release notes):
migrate package-no-name test to jest (629dac2)
move cli-alert out of test directory (b8a73c7)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@lili2311 lili2311 marked this pull request as ready for review June 10, 2021 14:26
@lili2311 lili2311 requested a review from a team as a code owner June 10, 2021 14:26
@lili2311 lili2311 merged commit 25acaff into master Jun 11, 2021
@lili2311 lili2311 deleted the fix/partition-by-fixable branch June 11, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants