feat: resolveAndTestFacts with async polling #2025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthogez
commented
Jun 15, 2021
| plugin, | ||
| scanResultsByPath, | ||
| ); | ||
| } |
There was a problem hiding this comment.
At the current stage I preferred to keep this logic as part of testDependencies instead of create a completely new flow for resolveAndTestFacts, have time to change it when required
anthogez
commented
Jun 15, 2021
src/lib/ecosystems/test.ts
Outdated
| options, | ||
| 2000, | ||
| ); | ||
| results.push(response); |
There was a problem hiding this comment.
Keeping the current approach where we test/resolve one scanResult at the time.
Depending of resolution AVG time for C/C++ unmanaged, we can change it to something like:
- Please generate a token (resolution process) for all the scanResults (if they are resolvable kind)
then go over that list and keep polling each token in order to see if any is available, if yes then take out of the list till all the scanResults' token are processed either successfully or not
anthogez
force-pushed
the
feat/support-polling-unmanaged-ecosystem
branch
4 times, most recently
from
e8e6092
to
9288497
Compare
anthogez
commented
Jun 15, 2021
|
|
||
| expect(testResults).toEqual([ | ||
| { | ||
| components: [ |
There was a problem hiding this comment.
this will change to depGraph & issuesData
anthogez
force-pushed
the
feat/support-polling-unmanaged-ecosystem
branch
from
9288497
to
abe74f5
Compare
src/lib/ecosystems/polling.ts
Outdated
| attemptsCount, | ||
| ), | ||
| ); | ||
| }), |
There was a problem hiding this comment.
Are you missing the second argument to setTimeout here?
| name: 'my-unmanaged-c-project', | ||
| facts: [ | ||
| { | ||
| type: 'signatures', |
There was a problem hiding this comment.
We called this 'cpp-signatures' in feat/support-c-addon here.
There was a problem hiding this comment.
Good point, we are moving to fileSignatures
anthogez
force-pushed
the
feat/support-polling-unmanaged-ecosystem
branch
3 times, most recently
from
e645519
to
653448e
Compare
anthogez
force-pushed
the
feat/support-polling-unmanaged-ecosystem
branch
4 times, most recently
from
bf81d23
to
99894bc
Compare
anthogez
force-pushed
the
feat/support-polling-unmanaged-ecosystem
branch
4 times, most recently
from
08df3a6
to
4fd0858
Compare
Introduces async request for C/C++ with polling, where its Facts are resolved/computed in our platform
anthogez
force-pushed
the
feat/support-polling-unmanaged-ecosystem
branch
from
4fd0858
to
9ed6542
Compare
anthogez
added a commit
that referenced
this pull request
Jul 15, 2021
Initial support for async test of unmanaged ecosystems e.g. c/c++ adding polling to resolve and test fileSignatures fact. The pr that will introduce the active usage of it will come later on. These changes comes from #2025 Using chore as prefix, because at the moment it's not bringing any effective feat yet.
anthogez
added a commit
that referenced
this pull request
Jul 16, 2021
Initial support for async test of unmanaged ecosystems e.g. c/c++ adding polling to resolve and test fileSignatures fact. The pr that will introduce the active usage of it will come later on. These changes comes from #2025 Using chore as prefix, because at the moment it's not bringing any effective feat yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces async request for C/C++ with polling, where its Facts are resolved/computed in our platform