Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/ci optimization #2148

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Chore/ci optimization #2148

merged 2 commits into from
Aug 11, 2021

Conversation

maxjeffos
Copy link
Contributor

What does this PR do?

A few optimizations to the CI pipeline ahead of #2105.

@maxjeffos maxjeffos requested review from a team as code owners August 9, 2021 19:29
@maxjeffos maxjeffos requested a review from orsagie August 9, 2021 19:29
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2021

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 906e766

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. What kind of performance improvements do we see with using Large in these cases? Just wondering in terms of cost/benefit. (We had to do it for the other jobs because of memory issues, whereas here we don't have that problem AFAIK)

@maxjeffos
Copy link
Contributor Author

Looks good. What kind of performance improvements do we see with using Large in these cases? Just wondering in terms of cost/benefit. (We had to do it for the other jobs because of memory issues, whereas here we don't have that problem AFAIK)

I don't think this is just for performance. @JackuB knows as this is basically from his big webpack PR, but I think he needed to bump these up to get it to finish, not just for performance.
@JackuB can you confirm?

@JackuB
Copy link
Contributor

JackuB commented Aug 11, 2021

Yes, #2105 was running OOM when generating source maps

@maxjeffos maxjeffos merged commit 104b07d into master Aug 11, 2021
@maxjeffos maxjeffos deleted the chore/ci-optimization branch August 11, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants