chore: remove update notifier #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avishagp
force-pushed
the
chore/remove-update-notifier
branch
from
1254d4f
to
cb76355
Compare
maxjeffos
force-pushed
the
chore/remove-update-notifier
branch
from
cb76355
to
6b91de7
Compare
maxjeffos
commented
Aug 11, 2021
| @@ -5,7 +5,7 @@ | |||
| "pretty": true, | |||
| "moduleResolution": "node", | |||
| "target": "es2018", | |||
| "lib": ["ES2018", "dom"], | |||
| "lib": ["ES2018", "ES2019", "dom"], | |||
There was a problem hiding this comment.
@maxjeffos Yeah, seen that trick. But it still doesn't make sense that the test is broken only for this PR right?
There was a problem hiding this comment.
@Avishagp, I have theory... I was thinking that since update-notifier has many deps/transitive deps, along with @types/update-notifier, probably something in those deps was defining Object.fromEntries. I think it's quite likely the case.
There was a problem hiding this comment.
That totally makes sense. Thanks!
Avishagp
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the update notification mechanism along with the
update-notifierdependency.This is a pre-PR to #2105