Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use async/await instead of callbacks #2156

Merged
1 commit merged into from
Aug 12, 2021
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 11, 2021

As promised in #1968. I've migrated this test to use async/await for better readability.

@ghost ghost requested review from a team as code owners August 11, 2021 17:55
@ghost ghost requested review from orsagie and maxjeffos August 11, 2021 17:55
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2021

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 1fec66e

Copy link
Contributor

@maxjeffos maxjeffos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @jahed-snyk

test/jest/acceptance/cli-json-file-output.spec.ts Outdated Show resolved Hide resolved
@ghost ghost force-pushed the test/json-file-output-cleanup branch from e6c1501 to 1fec66e Compare August 12, 2021 11:04
@ghost ghost merged commit 2f32793 into master Aug 12, 2021
@ghost ghost deleted the test/json-file-output-cleanup branch August 12, 2021 13:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant