Use OAUTH token if set for analytics #2159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Aug 12, 2021
| headers: { | ||
| host: 'localhost:12345', | ||
| accept: 'application/json', | ||
| authorization: 'Bearer oauth-jwt-token', |
There was a problem hiding this comment.
We can be less verbose in this test case and just match on the authorization header since that's all we care about.
| expect(code).toBe(0); | ||
|
|
||
| const lastRequest = server.popRequest(); | ||
| expect(lastRequest).toMatchObject({ |
There was a problem hiding this comment.
Could do something like not.toHaveProperty('headers.authorization') to be less verbose.
src/lib/api-token.ts
Outdated
| const oauthToken: string | undefined = getOAuthToken(); | ||
| const dockerToken: string | undefined = getDockerToken(); | ||
| const apiToken: string | undefined = api(); | ||
| return Boolean(oauthToken || dockerToken || apiToken); |
There was a problem hiding this comment.
We can inline these variables. I don't think naming them adds much, makes it more noisy (esp. with type annotations). And maybe check for api() first as it's the most common.
maxjeffos
force-pushed
the
fix/use-oauth-token-for-analytics
branch
3 times, most recently
from
e105239
to
210c44c
Compare
maxjeffos
force-pushed
the
fix/use-oauth-token-for-analytics
branch
from
210c44c
to
14a0b76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update Analytics to use the OAUTH token if it is set.