refactor: replace cc parser with split functions [CC-1021] #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aron
reviewed
Aug 16, 2021
almog27
force-pushed
the
refactor/replace-cc-parser-with-split-functions
branch
from
08a6088
to
8b65497
Compare
ipapast
reviewed
Aug 16, 2021
almog27
force-pushed
the
refactor/replace-cc-parser-with-split-functions
branch
from
8b65497
to
c8135f2
Compare
teodora-sandu
requested changes
Aug 16, 2021
src/cli/commands/test/iac-local-execution/extract-line-number.ts
Outdated
Show resolved
Hide resolved
src/cli/commands/test/iac-local-execution/extract-line-number.ts
Outdated
Show resolved
Hide resolved
ipapast
changed the title
almog27
force-pushed
the
refactor/replace-cc-parser-with-split-functions
branch
from
ab88d74
to
86aee3d
Compare
teodora-sandu
approved these changes
Aug 17, 2021
almog27
force-pushed
the
refactor/replace-cc-parser-with-split-functions
branch
from
86aee3d
to
c200e4c
Compare
almog27
force-pushed
the
refactor/replace-cc-parser-with-split-functions
branch
from
c200e4c
to
1ed7d11
Compare
almog27
commented
Aug 17, 2021
| @@ -147,7 +147,7 @@ | |||
| "devDependencies": { | |||
| "@types/cross-spawn": "^6.0.2", | |||
| "@types/fs-extra": "^9.0.11", | |||
| "@types/jest": "^26.0.20", | |||
| "@types/jest": "^27.0.1", | |||
There was a problem hiding this comment.
This dependency was updated due to failure in regression tests due to the fact that the jest dependency is a newer version than the types
JackuB
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the version of the
cloud-config-parserdependency to use a newer version that takes care of a performance issue.Instead of calculating the treeMap for each line in the file, we are calculating the treeMap once for each file, and sending it to the parser to get the correct line number.
Therefore, for a file that has multiple issues, we only calculate the treeMap once.
Where should the reviewer start?
How should this be manually tested?
snyk iac testwith--jsonor--sarifflags.What are the relevant tickets?
Jira Ticket CC-1021
Snapshots