test: server.close uses callbacks, not promises #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some tests, we assume server.close uses promises. It doesn't. Meaning in those tests we end the test before the server closes, causing possible issues (e.g. we don't randomise the port so we're bound to get port conflicts as a race condition).
I used a mixture of callbacks and promise wrappers because that's how it currently is for similar tests. It'll make migrations easier in the future.
I considered adding an API to
fakeServerto support promises but it'll change a lot of tests and some are using a different "fake server" calledcli-server. Ideally we should migratecli-serverusage tofakeServerthen make API changes to avoid duplication.