chore(ci): lint before build #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
maxjeffos
approved these changes
Sep 3, 2021
This was referenced Nov 28, 2023
This was referenced Nov 29, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have to wait for the build to finish (1 minute+) before the linters tell us about formatting issues. Linting issues should be flagged ASAP so developers can fix their code quickly and push again before waiting for slow builds and tests to run.
In the future we want ideally want to be in this speed-based workflow:
Lint -> Fast Test (Unit) -> Build -> Slow Tests (Acceptance)