Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove package-lock and ignore it #223

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

miiila
Copy link
Contributor

@miiila miiila commented Sep 24, 2018

DON'T MERGE

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Removes package-lock.json and prevents adding it in the future. We'd like to ignore the lockfile in order to have the most similar depency tree during test runs, as it would be after installing snyk as a library.

@miiila miiila self-assigned this Sep 24, 2018
Copy link
Contributor

@adrukh adrukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust pr comment to explain the reason behind this move as you see it. A link to a slack comment won’t be visible to external contributors.

@darscan
Copy link
Contributor

darscan commented Sep 27, 2018

@miiila I'd be happy to see this go in :)

@lili2311 lili2311 merged commit 3af11b8 into master Oct 2, 2018
@lili2311 lili2311 deleted the chore/remove-package-lock branch October 2, 2018 11:46
@snyksec
Copy link

snyksec commented Oct 3, 2018

🎉 This PR is included in version 1.100.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants