Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove scanResult from json output [MAGMA-1280] #2502

Merged
merged 5 commits into from
Jan 6, 2022
Merged

fix: Remove scanResult from json output [MAGMA-1280] #2502

merged 5 commits into from
Jan 6, 2022

Commits on Jan 5, 2022

  1. fix: Remove scanResult from json output 

    The scanResult object was added to the json output where
it should only have been added to calculate the the
dockerfile warning string.
This change removes the scanResult from the json output
as it was not supposed to be exposed.
    @snaftaly
    snaftaly committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    fcff339 View commit details
    Browse the repository at this point in the history

  2. refactor: Change import style to ES6 syntax

    @snaftaly
    snaftaly committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    5d29d7f View commit details
    Browse the repository at this point in the history

  3. refactor: Strip json result array after formatting 

    This refactor is done to not have a special case for
array vs single result when formatting the results
for JSON output.
Note: dataToSend will now take the jsonData after formatting
rather than the data before formatting. Since the formatting
only changes the vulnerbilities and removes the unwanted
scanResult, and since the vulnerbilities are removed from
dataToSend before it is used, this change will not affect the
CLI bahvior except for removing the unwanted scanResult.
    @snaftaly
    snaftaly committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    8c93f31 View commit details
    Browse the repository at this point in the history

  4. refactor: Rename errorMappedResults to mappedResults 

    Renaming the object as in IaC the logic does more than mapping
the results.
    @snaftaly
    snaftaly committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    5805f4f View commit details
    Browse the repository at this point in the history

  5. refactor: Rename fixtures to align with variable name 

    Rename test fixtures used in format-test-results to align
with the variable name change.
This is done in a separate commit so it's clearer in git
history that the files were changed and then renamed rather
than deleted and created new files.
    @snaftaly
    snaftaly committed Jan 5, 2022
    Configuration menu
    Copy the full SHA
    1949818 View commit details
    Browse the repository at this point in the history