docs: update code command help #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avishagp
reviewed
Jan 6, 2022
maxjeffos
previously requested changes
Jan 10, 2022
ArturSnyk
reviewed
Jan 11, 2022
I don't think so, although both use the |
|
The intention is to have only the information that applies to the `snyk
code` command in the help for that command.
…On Tue, Jan 11, 2022 at 7:52 AM Artur ***@***.***> wrote:
should the test command be explained the same as as the snyk test command?
I don't think so, although both use the test Those two are not under the
same execution path.
I would assume that with those changes when user will run snyk code --help
the will be missing some common explanations (ones that snyk test has)
—
Reply to this email directly, view it on GitHub
<#2513 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWWRPDDYTFQGLQMF5RTFGELUVQRXNANCNFSM5LGMYVYA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Avishagp
force-pushed
the
docs/revise-code-command-help
branch
from
86bf5a9
to
6db65bc
Compare
Avishagp
approved these changes
Jan 12, 2022
Avishagp
force-pushed
the
docs/revise-code-command-help
branch
from
6db65bc
to
83d5aa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file has all revisions through January 3, 2022, for review by the Hammer team. Question: For commands with the sub-command test, should the test command be explained the same as as the snyk test command: test a project for open source vulnerabilities and license issues? At this time, the code and iac commands say: test for any known issue. The container command says: test for any known vulnerabilities.