Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:adding beta language support #3011

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

shirlupo
Copy link
Contributor

@shirlupo shirlupo commented Mar 9, 2022

This PR is for supporting beta languages from feature flag supported in the cli

The flow starts from registry - who passes supported languages array including the beta languages that are supported by FF and sends it to code-client to exclude non necessary files.

The corresponding ticket is :

https://snyksec.atlassian.net/browse/NEBULA-347

@ghost
Copy link

ghost commented Mar 9, 2022

This PR modifies files linked to issues tracked in Stepsize. You might want to review their status, priority, and scope.

✅  2 http libraries in CLI
  • src/lib/plugins/sast/analysis.ts
Created from GitHub PR snyk/snyk/#2826
  • src/lib/plugins/sast/analysis.ts

 Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2022

Warnings
⚠️

You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against 2661367

@shirlupo shirlupo force-pushed the feat/adding-beta-language-support-cli branch from 32ececf to 30bab4e Compare March 9, 2022 15:51
@shirlupo shirlupo marked this pull request as ready for review March 10, 2022 07:31
@shirlupo shirlupo requested a review from a team as a code owner March 10, 2022 07:31
@shirlupo shirlupo requested review from a team, saark-snyk and metju90 March 10, 2022 07:31
Copy link
Contributor

@saark-snyk saark-snyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

Copy link
Contributor

@JackuB JackuB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a package-lock file update as well. See the contributing docs: https://github.com/snyk/cli/blob/master/CONTRIBUTING.md#adding-dependencies

@shirlupo shirlupo force-pushed the feat/adding-beta-language-support-cli branch from 30bab4e to cc973d5 Compare March 10, 2022 09:35
@shirlupo shirlupo force-pushed the feat/adding-beta-language-support-cli branch from cc973d5 to 2661367 Compare March 10, 2022 09:37
@shirlupo
Copy link
Contributor Author

Needs a package-lock file update as well. See the contributing docs: https://github.com/snyk/cli/blob/master/CONTRIBUTING.md#adding-dependencies

thank you - done

@shirlupo shirlupo requested a review from JackuB March 10, 2022 12:46
@shirlupo shirlupo enabled auto-merge March 15, 2022 12:22
@ArturSnyk ArturSnyk closed this Mar 15, 2022
auto-merge was automatically disabled March 15, 2022 12:23

Pull request was closed

@ArturSnyk ArturSnyk reopened this Mar 15, 2022
@shirlupo shirlupo merged commit c8fa31b into master Mar 15, 2022
@shirlupo shirlupo deleted the feat/adding-beta-language-support-cli branch March 15, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants