fix: support comments in python manifest in requirements line #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackuB
approved these changes
Mar 25, 2022
admons
force-pushed
the
fix/python-requirements-with-multiple-spaces
branch
from
d59cac0
to
4e319f0
Compare
today we fail in the case of '-r requirements # comment' line in the requirements.txt manifest file. this upgrade fixes it (and ignore the comments)
admons
force-pushed
the
fix/python-requirements-with-multiple-spaces
branch
from
4e319f0
to
e2449fa
Compare
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
today we fail in the case of '-r requirements # comment' line in the requirements.txt manifest file.
this upgrade fixes it (and ignore the comments)