chore: replace inquirer with enquirer #3074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robcresswell
approved these changes
Mar 29, 2022
jgresty
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
+1 for not using a vendored library
My only concern is that this is no longer readline based so it will probably provide a worse experience for some users who expect the shell to act a certain way. If you are fine with this UX then go ahead and make the change
Avishagp
force-pushed
the
chore/replace-inquirer-with-enquirer
branch
from
9c28633
to
4db4b62
Compare
JackuB
approved these changes
Mar 31, 2022
Avishagp
force-pushed
the
chore/replace-inquirer-with-enquirer
branch
from
4db4b62
to
4cf320d
Compare
Avishagp
force-pushed
the
chore/replace-inquirer-with-enquirer
branch
from
4cf320d
to
ed675be
Compare
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
@snyk/inquirerwithenquirer.@snyk/inquirerwas heavily used in wizard command (removed in #2799), and used in apps. enquirer is an easy replacement, offering a less dependencies.