test: get stdout failure text before exit code #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves all exit code assertions from the top assertion to the bottom. In this way we can see the stdout actual text first when a test fails. It will be even easier for checking it in CircleCI.
ipapast
force-pushed
the
test/update-iac-test-exit-code-assert
branch
from
b232184
to
8c392a4
Compare
francescomari
approved these changes
Apr 5, 2022
1 task
This was referenced Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a non functional change, just reordering the assertions in our iac acceptance tests.
So far, if a test fails - we will only see the exit code assertion and not the actual reason why.
This commit moves all exit code assertions from the top assertion to the bottom.
In this way we can see the stdout actual text first when a test fails. It will be even easier for checking it in CircleCI.
example before: