chore: Send integrated IaC test analytics [CFG-2169] #3882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofekatr
changed the title
ofekatr
force-pushed
the
chore/send-integrated-iac-test-analytics-cfg-2169
branch
from
29d7ce1
to
70dfcc0
Compare
ofekatr
requested review from
francescomari
and removed request for
YairZ101
ofekatr
force-pushed
the
chore/send-integrated-iac-test-analytics-cfg-2169
branch
from
70dfcc0
to
acf4c5c
Compare
francescomari
approved these changes
Sep 29, 2022
ofekatr
deleted the
chore/send-integrated-iac-test-analytics-cfg-2169
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Where should the reviewer start?
Any background context you want to provide?
In CFG-2157 we’ve computed the analytics we would like to save and after coordinating with BI we are ready to send them over the network to be saved.
BI clarified that the new analytics should be saved in
snyk_cli_was_run(which is the new 2nd “version” ofcli_tracking_data).The CLI is using the add function to add new data to the metadata field of the analytics, then at the end of each scan the CLI sends those analytics to registry to get processed and then saved, Avishag from team hammer confirmed that this data is saved in both cli_tracking_data and snyk_cli_was_run.
What are the relevant tickets?