chore: upgrade node to 14; node 12 is end of life #4146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 12 went end of life on April 30, 2022. See: https://twitter.com/nodejs/status/1524081123579596800 See: https://github.com/nodejs/Release#release-schedule Signed-off-by: Craig Andrews <candrews@integralblue.com>
|
@PeterSchafer hopefully this small PR passes all tests and is very easy to merge :) |
|
Node12 support was deprecated in v1.1203.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stops testing with node 12 and drops support for it.
Node 12 went end of life on April 30, 2022.
See: https://twitter.com/nodejs/status/1524081123579596800
See: https://github.com/nodejs/Release#release-schedule
Where should the reviewer start?
By running the tests, building the project... there shouldn't be any differences.
How should this be manually tested?
Run snyk cli, use it as usual
Any background context you want to provide?
I'm splitting out some of the changes in #3875 into separate PRs for easier review/merging.
What are the relevant tickets?
n/a
Screenshots
n/a
Additional questions
n/a