feat: pass oauth token to sast, if available #4196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR modifies files linked to issues tracked in Stepsize. You might want to review their status, priority, and scope.
|
DarrellMozingo
force-pushed
the
pass-oauth-token-to-code
branch
from
e268ec8
to
7c4d966
Compare
|
This PR modifies files linked to issues tracked in Stepsize. You might want to review their status, priority, and scope.
|
DarrellMozingo
force-pushed
the
pass-oauth-token-to-code
branch
2 times, most recently
from
dd0ecb3
to
e966732
Compare
|
Hey @DarrellMozingo, |
This allows SNYK_OAUTH_TOKEN support instead of just API Key. Also passes proper authn scheme (token or bearer), as only sending the API key is deprecated. The Snyk Code backend has already been modified to accept the new authn material.
DarrellMozingo
force-pushed
the
pass-oauth-token-to-code
branch
from
e966732
to
5f01d8d
Compare
PeterSchafer
approved these changes
Jan 11, 2023
novalex
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows SNYK_OAUTH_TOKEN support instead of just API Key.
What does this PR do?
Passes an OAuth token into the SAST backend if specified.
Where should the reviewer start?
The tests:
test/jest/unit/snyk-code/snyk-code-test.spec.tsHow should this be manually tested?
SNYK_OAUTH_TOKEN=$token snyk code testAny background context you want to provide?
Previously we only passed the api key as an auth header.
This method is deprecated (no
tokenscheme), and doesn't support OAuth tokens. Use existing header building to do this, so we sendbearer $jwtif specified.The backend has already been updated to handle this.
What are the relevant tickets?
Screenshots
Additional questions