Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update os-name and adapt import #4252

merged 1 commit into from Dec 27, 2022


Copy link

@PeterSchafer PeterSchafer commented Dec 17, 2022

What does this PR do?

  • Update npm package os-name
  • Since os-name changed to a pure ESM package, the usage of require() was replaced or the usage of the package was avoided

Copy link

github-actions bot commented Dec 17, 2022


Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • test/tap/cli-monitor.acceptance.test.ts

Generated by 🚫 dangerJS against b2b49b7

@PeterSchafer PeterSchafer force-pushed the chore/HMMR-608_update_osname branch 2 times, most recently from f4642d2 to df342bb Compare December 19, 2022 18:01
* replace using osName() to determine isWindows by os.platform()
@PeterSchafer PeterSchafer requested a review from a team as a code owner December 19, 2022 18:23
Copy link

@strassl-snyk strassl-snyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @snyk/zenith

@PeterSchafer PeterSchafer merged commit 108f41e into master Dec 27, 2022
12 checks passed
@PeterSchafer PeterSchafer deleted the chore/HMMR-608_update_osname branch December 27, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants