Skip to content

chore: update os-name and adapt import#4252

Merged
PeterSchafer merged 1 commit intomasterfrom
chore/HMMR-608_update_osname
Dec 27, 2022
Merged

chore: update os-name and adapt import#4252
PeterSchafer merged 1 commit intomasterfrom
chore/HMMR-608_update_osname

Conversation

@PeterSchafer
Copy link
Contributor

@PeterSchafer PeterSchafer commented Dec 17, 2022

What does this PR do?

  • Update npm package os-name
  • Since os-name changed to a pure ESM package, the usage of require() was replaced or the usage of the package was avoided

@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2022

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • test/tap/cli-monitor.acceptance.test.ts

Generated by 🚫 dangerJS against b2b49b7

@PeterSchafer PeterSchafer force-pushed the chore/HMMR-608_update_osname branch 2 times, most recently from f4642d2 to df342bb Compare December 19, 2022 18:01
* replace using osName() to determine isWindows by os.platform()
@PeterSchafer PeterSchafer force-pushed the chore/HMMR-608_update_osname branch from df342bb to b2b49b7 Compare December 19, 2022 18:23
@PeterSchafer PeterSchafer requested a review from a team December 19, 2022 18:23
Copy link
Member

@strassl-snyk strassl-snyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for @snyk/zenith

@PeterSchafer PeterSchafer merged commit 108f41e into master Dec 27, 2022
@PeterSchafer PeterSchafer deleted the chore/HMMR-608_update_osname branch December 27, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants