fix: host URL for instances in different regions #4374
Conversation
PeterSchafer
force-pushed
the
fix/license_urls
branch
3 times, most recently
from
4bda823
to
1b8a5f7
Compare
PeterSchafer
requested review from
aron,
danielroymoore and
alexandru-dragomir
src/lib/config/api-url.ts
Outdated
| // given an api url that starts with api means, that we can replace "api" by "app". | ||
|
|
||
| const apiUrl = new URL(apiUrlString); | ||
| apiUrl.host = apiUrl.host.replace(/^api\./, 'app.'); |
There was a problem hiding this comment.
what about https://snyk.io/api? That should become https://app.xx.snyk.io/api, right?
There was a problem hiding this comment.
I guess, what I want to say is that you don't always have an api subdomain ;).
There was a problem hiding this comment.
Absolutely correct, we might not have "api" sub-domains which is fine, they remain unaltered. As far as I understood, https://snyk.io/api is the legacy, still supported url.
There was a problem hiding this comment.
After discussing with @bastiandoetsch offline, we decided to reduce the impact of the change a bit, by replacing "api." by an empty string only, not replacing by "app.". Which is basically what was there before just that we keep Urls that have "app." already unaltered.
PeterSchafer
force-pushed
the
fix/license_urls
branch
from
1b8a5f7
to
4667d6c
Compare
What does this PR do?
Previously we assumed that the root hostname shouldn't start with "app." but this is actually the consistent endpoint for cross region usage.