feat: improve deployment testing #4382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* split deployment into stages (pre-release, release testing, final release)
| @@ -10,6 +10,6 @@ echo 'Running "npm install binary-releases/snyk.tgz"...' | |||
| npm install $releaseTar | |||
|
|
|||
| echo 'Validating "snyk" command succeeds...' | |||
| ./node_modules/snyk/bin/snyk | |||
| ./node_modules/snyk/bin/snyk -d | |||
There was a problem hiding this comment.
Is -d safe or could it leak environment variables?
There was a problem hiding this comment.
Great question, first of all CircleCI or most CI/CD redact the content of Environment Variables in the logs, second, we try to not log sensitive content and especially in this case it should be pretty safe.
There was a problem hiding this comment.
The reason I added it is, that it helps us see the changes we are making at the very end before deployment.
bastiandoetsch
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Split deployment into the following stages (in preparation for HEAD-57)
Test Release now runs on the three main OS (linux, win, macos)
Where should the reviewer start?
.circleci/config.yml
How should this be manually tested?