Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SARIF: artifactChanges property cannot be empty #5010

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix: SARIF: artifactChanges property cannot be empty #5010

merged 1 commit into from
Jan 19, 2024

Conversation

schottsfired
Copy link
Collaborator

We received a report that artifactChanges: [] causes an error in GitHub:

Unable to upload "xyz.sarif" as it is not valid SARIF:

  • instance.runs[2].results[0].fixes[0].artifactChanges does not meet minimum length of 1

cf. https://docs.oasis-open.org/sarif/sarif/v2.1.0/errata01/os/sarif-v2.1.0-errata01-os-complete.html#_Toc141791134

This fix populates artifactChanges so it's not empty.

@schottsfired schottsfired requested a review from a team as a code owner January 18, 2024 21:58
cmars
cmars approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@cmars cmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmars cmars enabled auto-merge (squash) January 19, 2024 00:13
@cmars cmars mentioned this pull request Jan 19, 2024
Closed
@cmars cmars merged commit 2dd4f9e into snyk:master Jan 19, 2024
20 checks passed
@schottsfired schottsfired deleted the fix/addl-sarif-data branch January 19, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmars cmars cmars approved these changes

@bastiandoetsch bastiandoetsch bastiandoetsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@schottsfired @cmars @bastiandoetsch