Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce script to create release #5116

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

j-luong
Copy link
Contributor

@j-luong j-luong commented Mar 13, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

Introduces a script that can be used to create releases by checking for major/minor or patch changes and updating/creating branches as appropriate.

Where should the reviewer start?

Run the script ./release-scripts/create-release.sh to create/update the release branch.

How should this be manually tested?

If you want to test without creating any branches, then pass the dry-run arg to the ./release-script/create-release.sh script e.g. ./release-scripts/create-release.sh dry-run

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@j-luong j-luong force-pushed the chore/CLI-151_RCreleaseScript branch 7 times, most recently from 5b88926 to 76320af Compare March 14, 2024 14:44
@j-luong j-luong marked this pull request as ready for review March 14, 2024 14:44
@j-luong j-luong requested a review from a team as a code owner March 14, 2024 14:44

if [[ $DRY_RUN_MODE == true ]]; then
echo "Dry running git push"
git push --dry-run origin $MAJOR_MINOR_BRANCH
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: do we want to delete the old release/${manjor}.${minor} branch after pushing the new one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think so, I believe there is value in those branches existing for a period of time after release as a target for hotfixes.


# Validate versions are the same
if [[ "$CURRENT_VERSION" != "$RELEASE_VERSION" ]]; then
echo "Version file version: '$CURRENT_VERSION', is not equal to RELEASE_NOTES.md version: '$RELEASE_VERSION'. Please ensure the versions are equal before continuing."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: What would be the steps required in this scenario to rectify the issue. Can we document them, either as part of this output or externally and link to them?

@thisislawatts thisislawatts merged commit cd8eb6c into main Mar 19, 2024
14 checks passed
@thisislawatts thisislawatts deleted the chore/CLI-151_RCreleaseScript branch March 19, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants