-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parse workflow data to determine errors #5157
Merged
thisislawatts
merged 22 commits into
main
from
feat/parse-workflow-data-to-determine-errors
Apr 15, 2024
Merged
feat: parse workflow data to determine errors #5157
thisislawatts
merged 22 commits into
main
from
feat/parse-workflow-data-to-determine-errors
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a4404b
to
ac2e0d9
Compare
thisislawatts
commented
Apr 10, 2024
thisislawatts
commented
Apr 10, 2024
if strings.EqualFold(mimeType, "application/json; type=snyk-test-summary") { | ||
singleData, ok := data[i].GetPayload().([]byte) | ||
if !ok { | ||
return fmt.Errorf("invalid payload type: %T", data[i].GetPayload()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: For error messages to be a bit more self explanatory maybe mention what failed and then the why.
285917a
to
e999cf6
Compare
508289a
to
00b5b23
Compare
1d170d1
to
00b5b23
Compare
2f650c7
to
8ecb782
Compare
25a2faa
to
ba5c029
Compare
We want to ensure that nothing is displayed for the new Error being generated from TestSummary payload
ba5c029
to
340cdac
Compare
7a9eec7
to
f85ca30
Compare
PeterSchafer
requested changes
Apr 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the open comments.
PeterSchafer
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:
orfix:
, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.Pull Request Review
All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.
Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.
For Node projects: It’s important to make sure changes in
package.json
are also affectingpackage-lock.json
correctly.If a dependency is not necessary, don’t add it.
When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.
Pull Request Approval
Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.
What does this PR do?
Allows exit code to be affected by data payloads generated as part of workflows.
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
What are the relevant tickets?