-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trigger re-analysis after fixing interfile issues [IDE-178] #5163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSchafer
approved these changes
Apr 15, 2024
PeterSchafer
force-pushed
the
fix/IDE-178_fix_interfile_code_issues
branch
from
April 16, 2024 07:36
b169d96
to
b8c6a3e
Compare
This was referenced May 22, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:
orfix:
, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.What does this PR do?
This PR bumps Snyk-LS & Code-Client-Go. This enables correct automatic rescans in Snyk Code for interfile issues, where e.g. the cause of a problem is fixed in a different file, and the affected file is automatically fixed with the cause. This dataflow analysis was previously missing from re-scans, so the analysis was limited to too few files.
Risk: Low
Code-Client-Go is only used behind a feature flag. This updates to the latest version used in unified ignores (under development)
Risk: Low
Where should the reviewer start?
snyk/snyk-ls#486
How should this be manually tested?
Fire up IntelliJ, enable Snyk Code LS scanning, and scan a project with interfile issues. Fix the cause in one file, watch the issue disappear for the other file. I used juice-shop, it has some interfile issues.
Any background context you want to provide?
What are the relevant tickets?
IDE-178
Screenshots
Additional questions