Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sbom): Introduce experimental sbom test command #5176

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

paulrosca-snyk
Copy link
Contributor

@paulrosca-snyk paulrosca-snyk commented Apr 18, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

Updates cli-extension-sbom to its latest version.

The new version of the extension brings no changes to existing functionality (i.e sbom creation) and only adds a new command for testing sboms (i.e sbom test) which is only accessible using the --experimental flag.

We have also updated acceptance tests to test the new changes .

Risk assessment of the change: Low

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@paulrosca-snyk paulrosca-snyk changed the title wip: sbom test acceptance test feat: add sbom test command Apr 18, 2024
@paulrosca-snyk paulrosca-snyk force-pushed the feat/sbom-test-acceptance branch 3 times, most recently from e8a8352 to f8ba9ba Compare April 18, 2024 08:48
@paulrosca-snyk paulrosca-snyk marked this pull request as ready for review April 18, 2024 09:28
@paulrosca-snyk paulrosca-snyk requested a review from a team as a code owner April 18, 2024 09:28
@PeterSchafer
Copy link
Contributor

PeterSchafer commented Apr 18, 2024

Hey @paulrosca-snyk,

thank you for opening the PR! It looks almost perfect!

I would just like to suggest some improvements in the documentation of the change, which should help internal and external users to understand the changes better.

  1. For the PR title, which will end up in the release notes, please be a bit more descriptive for example like this feat(sbom): Introduce experimental sbom test command
  2. Help understand the risk of the change, does the upgrade of cli-extension-sbom include any other changes that could affect existing functionality ...? Please add a bit more information around this in the PR description.

Thank you for your support!

@paulrosca-snyk paulrosca-snyk changed the title feat: add sbom test command feat(sbom): Introduce experimental sbom test command Apr 18, 2024
@paulrosca-snyk paulrosca-snyk enabled auto-merge (squash) April 18, 2024 12:14
@paulrosca-snyk paulrosca-snyk enabled auto-merge (squash) April 18, 2024 12:18
@paulrosca-snyk paulrosca-snyk merged commit ea6293b into main Apr 18, 2024
15 checks passed
@paulrosca-snyk paulrosca-snyk deleted the feat/sbom-test-acceptance branch April 18, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants