-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sbom): Fix container purl generation for apt and rpm #5207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulrosca-snyk
force-pushed
the
fix/UNIFY-93-container-purls
branch
4 times, most recently
from
April 30, 2024 07:25
0023a4d
to
25f1ba8
Compare
paulrosca-snyk
force-pushed
the
fix/UNIFY-93-container-purls
branch
from
May 7, 2024 12:52
25f1ba8
to
d8ed61d
Compare
PeterSchafer
approved these changes
May 7, 2024
This was referenced Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:
orfix:
, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.Pull Request Review
All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.
Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.
For Node projects: It’s important to make sure changes in
package.json
are also affectingpackage-lock.json
correctly.If a dependency is not necessary, don’t add it.
When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.
Pull Request Approval
Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.
What does this PR do?
Bumps
snyk-docker-plugin
package to the latest version. The new version fixesPURL
generation forapt
andrpm
based container images by including thevendor
as a namespace in thePURL
as well as adding thedistro
qualifier, those are needed for properly identifying packages in order to test for vulnerabilities.Risk assessment of the change: Low
The new
PURLs
which we generate insnyk-docker-plugin
are validated at creation using thedep-graph
library so we can be sure we don't introducePURLs
which break this validation later in the system.Where should the reviewer start?
How should this be manually tested?
Running the
snyk container depgraph
/snyk container sbom
/snyk container test --print-graph
command on aapt
orrpm
based image should populate thepurl
fields on packages with valid purls including thevendor
as a namesace and thedistro
qualifier (e.gpkg:deb/debian/base-files@11.1%2Bdeb11u7?distro=debian-bullseye
)Any background context you want to provide?
What are the relevant tickets?
UNIFY-93
Screenshots
Additional questions