Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set target-reference value in the container monitor request UNIFY-124 #5269

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

adrobuta
Copy link
Contributor

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

Pull Request Review

All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.

Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.

For Node projects: It’s important to make sure changes in package.json are also affecting package-lock.json correctly.

If a dependency is not necessary, don’t add it.

When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.

Pull Request Approval

Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.

What does this PR do?

Adds support for the target-reference parameter for snyk container monitor command

Where should the reviewer start?

How should this be manually tested?

snyk container monitor gcr.io/distroless/nodejs:latest --platform=linux/arm64 --target-reference=target_reference_test

Any background context you want to provide?

https://snyksec.atlassian.net/wiki/spaces/RD/pages/2027487415/target-reference+argument+support+on+the+snyk+container+monitor+command

What are the relevant tickets?

https://snyksec.atlassian.net/browse/UNIFY-124

Screenshots

Screenshot 2024-05-29 at 11 40 24

Additional questions

@adrobuta adrobuta requested a review from a team as a code owner May 29, 2024 09:46
Copy link
Contributor

github-actions bot commented May 29, 2024

Warnings
⚠️

Please make changes to snyk help text in Gitbook. Changes will be automatically synchronised to Snyk CLI as a scheduled PR.
For more information, see: help/README.md.

Generated by 🚫 dangerJS against 51ed8f5

@adrobuta adrobuta force-pushed the feat/container-target-reference branch from 73d8218 to 34a9beb Compare May 29, 2024 11:37
Copy link
Contributor

@SteveShani SteveShani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a simple change :)

Is it worth adding a test? Do tests exist for CLI flags?

Copy link
Contributor

@cmars cmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test demonstrating that the option makes it through to a mocked API request would be great so we're sure this works, and we can ensure that it continues to work in the future through refactorings and other changes.

Questions:

  • Does this add the flag to other test and monitor commands as well?
  • Should container use the existing function generateMonitorMeta?
  • What is the plan for updating user documentation and --help, given this is a user-facing change?

@adrobuta adrobuta force-pushed the feat/container-target-reference branch 2 times, most recently from 4433737 to 23c6a06 Compare June 4, 2024 07:05
@adrobuta
Copy link
Contributor Author

adrobuta commented Jun 4, 2024

@SteveShani @cmars thanks for the review!
The last re-spin of the PR addresses some of the raised points:

  • A test has been added to check if the options gets forwarded to the monitor endpoint.
  • I have updated the container monitor help doc to contain the newly added option.

The flag is added only to container monitor command, not affecting other test/monitor commands.
For the moment, generateMonitorMeta can't be used for container monitor because that would imply some refactoring of the code which is outside of the scope of this PR.

@adrobuta adrobuta force-pushed the feat/container-target-reference branch 7 times, most recently from cb63fef to 08727f4 Compare June 5, 2024 05:58
@adrobuta adrobuta requested a review from cmars June 5, 2024 10:20
@adrobuta adrobuta force-pushed the feat/container-target-reference branch from 08727f4 to a2ef486 Compare June 6, 2024 14:26
Copy link
Contributor

@cmars cmars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

@adrobuta adrobuta force-pushed the feat/container-target-reference branch from a2ef486 to 51ed8f5 Compare June 7, 2024 05:11
@adrobuta adrobuta merged commit d31a465 into main Jun 7, 2024
15 checks passed
@adrobuta adrobuta deleted the feat/container-target-reference branch June 7, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants