-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set target-reference value in the container monitor request UNIFY-124 #5269
Conversation
|
73d8218
to
34a9beb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such a simple change :)
Is it worth adding a test? Do tests exist for CLI flags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test demonstrating that the option makes it through to a mocked API request would be great so we're sure this works, and we can ensure that it continues to work in the future through refactorings and other changes.
Questions:
- Does this add the flag to other
test
andmonitor
commands as well? - Should container use the existing function generateMonitorMeta?
- What is the plan for updating user documentation and
--help
, given this is a user-facing change?
4433737
to
23c6a06
Compare
@SteveShani @cmars thanks for the review!
The flag is added only to container monitor command, not affecting other test/monitor commands. |
cb63fef
to
08727f4
Compare
08727f4
to
a2ef486
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks!
a2ef486
to
51ed8f5
Compare
Pull Request Submission
Please check the boxes once done.
The pull request must:
feat:
orfix:
, others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.Pull Request Review
All pull requests must undergo a thorough review process before being merged.
The review process of the code PR should include code review, testing, and any necessary feedback or revisions.
Pull request reviews of functionality developed in other teams only review the given documentation and test reports.
Manual testing will not be performed by the reviewing team, and is the responsibility of the author of the PR.
For Node projects: It’s important to make sure changes in
package.json
are also affectingpackage-lock.json
correctly.If a dependency is not necessary, don’t add it.
When adding a new package as a dependency, make sure that the change is absolutely necessary. We would like to refrain from adding new dependencies when possible.
Documentation PRs in gitbook are reviewed by Snyk's content team. They will also advise on the best phrasing and structuring if needed.
Pull Request Approval
Once a pull request has been reviewed and all necessary revisions have been made, it is approved for merging into
the main codebase. The merging of the code PR is performed by the code owners, the merging of the documentation PR
by our content writers.
What does this PR do?
Adds support for the target-reference parameter for snyk container monitor command
Where should the reviewer start?
How should this be manually tested?
snyk container monitor gcr.io/distroless/nodejs:latest --platform=linux/arm64 --target-reference=target_reference_test
Any background context you want to provide?
https://snyksec.atlassian.net/wiki/spaces/RD/pages/2027487415/target-reference+argument+support+on+the+snyk+container+monitor+command
What are the relevant tickets?
https://snyksec.atlassian.net/browse/UNIFY-124
Screenshots
Additional questions