feat: add branch and pkg name to monitor analytics #543
Conversation
src/lib/monitor.ts
Outdated
| analytics.add('branch', target.branch); | ||
| } | ||
|
|
||
| analytics.add('projectName', pkg.name); |
There was a problem hiding this comment.
project name will be calculated in Registry in the end and will unlikely be this name. Another important property is --project-name option as it is the project name override that is also used to calculate project name on the other end
There was a problem hiding this comment.
thanks @lili2311 that's good to know. so that's why we're not sending it from CLI i guess... ok I'll talk to the BI team about it since it was their request and see if pkg name is enough for them and why they need that. pkg.name will always b there though no?
There was a problem hiding this comment.
ok @lili2311 looks like we can send the ID as the project name from my few tests... wdyt?
There was a problem hiding this comment.
which ID? Cli never knows if there is an existing project or not until we monitor. So when monitor returns an id thats the only time we have something solid. Will that be enough?
There was a problem hiding this comment.
the meta.id one... looks like it's similar to the project name? or is it just in npm and maven?
odinn1984
force-pushed
the
feat/add_monitor_branch_pname_analytics
branch
from
188ebd8
to
ece0759
Compare
odinn1984
force-pushed
the
feat/add_monitor_branch_pname_analytics
branch
3 times, most recently
from
55650d4
to
cb883ea
Compare
odinn1984
force-pushed
the
feat/add_monitor_branch_pname_analytics
branch
from
cb883ea
to
b91d2ae
Compare
|
🎉 This PR is included in version 1.171.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does this PR do?
We want to add branch and project name to the data that we send to analytics.