Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ignore empty fixedIn arrays #739

Merged
merged 1 commit into from Aug 20, 2019
Merged

fix: Ignore empty fixedIn arrays #739

merged 1 commit into from Aug 20, 2019

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Aug 20, 2019 •
edited

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

  • Ignore empty fixedIn arrays
  • Update test fixture to show a diverse set of remediations

Screenshots

Before

Screen Shot 2019-08-20 at 13 36 19

After
Screen Shot 2019-08-20 at 13 35 50

@lili2311 lili2311 requested a review from a team as a code owner August 20, 2019 12:36
@lili2311 lili2311 self-assigned this Aug 20, 2019
@ghost ghost requested review from miiila and orsagie August 20, 2019 12:37
@lili2311 lili2311 merged commit 5dbf591 into master Aug 20, 2019
@lili2311 lili2311 deleted the fix/ignore-empty-fixed-in-arrays branch August 20, 2019 12:59
@snyksec
Copy link

snyksec commented Aug 25, 2019

🎉 This PR is included in version 1.218.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@snyk-bot snyk-bot mentioned this pull request Jan 1, 2020
Merged
This was referenced Jul 9, 2020
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Aug 7, 2020
Open
This was referenced Aug 16, 2020
Open
Open
Open
Open
This was referenced Aug 27, 2020
Open
Open
Open
Open
@EitanGayor EitanGayor mentioned this pull request Feb 22, 2021
Open
@romathur romathur mentioned this pull request Feb 22, 2021
Open
@EitanGayor EitanGayor mentioned this pull request Feb 23, 2021
Open
@joshje joshje mentioned this pull request Feb 23, 2021
Open
@RyanPHigh RyanPHigh mentioned this pull request Feb 23, 2021
Open
@robin-qualityengineer robin-qualityengineer mentioned this pull request May 23, 2022
Open
This was referenced May 23, 2022
Open
Open
@froscheimer froscheimer mentioned this pull request May 24, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 24, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jun 24, 2022
Open
@EitanGayor EitanGayor mentioned this pull request Jun 30, 2022
Open
This was referenced Jul 27, 2022
Closed
Closed
@aliscco aliscco mentioned this pull request Aug 5, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2022
Open
This was referenced Sep 25, 2022
Open
Open
This was referenced Sep 30, 2022
Open
Open
@aliscco aliscco mentioned this pull request Oct 2, 2022
Open
@shaniHerz shaniHerz mentioned this pull request Oct 3, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 4, 2022
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 29, 2022
Open
This was referenced Feb 19, 2023
Merged
Merged
Open
@cloudgeek7 cloudgeek7 mentioned this pull request Mar 15, 2023
Open
@AliADDOU AliADDOU mentioned this pull request Apr 15, 2024
Open
@romathur romathur mentioned this pull request Apr 16, 2024
Open
@RyanPHigh RyanPHigh mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miiila miiila miiila approved these changes

@orsagie orsagie Awaiting requested review from orsagie

Assignees

@lili2311 lili2311

Labels
released
Projects
None yet
Milestone
No milestone
3 participants
@lili2311 @snyksec @miiila