feat: enable paket to be autodetected with --all-projects #978
Conversation
ghost
requested review from
| @@ -39,6 +39,7 @@ export const AUTO_DETECTABLE_FILES: string[] = [ | |||
| 'Gemfile.lock', | |||
| 'pom.xml', | |||
| 'packages.config', | |||
| 'paket.dependencies', | |||
There was a problem hiding this comment.
paket.lock needed here also?
There was a problem hiding this comment.
We only detect paket.dependencies, we won't do paket.lock by itself (the plugin will detect it)
There was a problem hiding this comment.
But why then Gemfile we detect both? And for npm we detect package-lock.json and for yarn yarn.lock?
There was a problem hiding this comment.
Gemfile is good point - plugin seems to throw error if no Gemfile.lock is found, so should Gemfile be in this list? I think npm plugin can handle either package-lock.json or package.json so that's ok
There was a problem hiding this comment.
Gemfile is not really needed no, the rest is all determined by the plugin really and what it can find itself and what it needs to be detected by us. Me and Daniel spoke about this in a different PR, we can go back and tidy up some of these afterwards.
There was a problem hiding this comment.
for ruby we find the Gemfile.lock later in the plugin so just Gemfile will be fine, see `gatherSpecs. Let's keep that a separate PR
There was a problem hiding this comment.
Yeah, just wanted to clarify. We should do a tidy up PR afterward
| @@ -26,6 +26,9 @@ export const AllProjectsTests: AcceptanceTests = { | |||
| t.ok(spyPlugin.withArgs('rubygems').calledOnce, 'calls rubygems plugin'); | |||
| t.ok(spyPlugin.withArgs('npm').calledOnce, 'calls npm plugin'); | |||
| t.ok(spyPlugin.withArgs('maven').calledOnce, 'calls maven plugin'); | |||
| t.ok(spyPlugin.withArgs('nuget').calledOnce, 'calls nuget plugin'); | |||
| t.ok(spyPlugin.withArgs('paket').calledOnce, 'calls nuget plugin'); | |||
There was a problem hiding this comment.
The paket plugin is the nuget plugin
| @@ -21,8 +21,10 @@ export const AllProjectsTests: AcceptanceTests = { | |||
| t.ok(spyPlugin.withArgs('rubygems').calledOnce, 'calls rubygems plugin'); | |||
| t.ok(spyPlugin.withArgs('npm').calledOnce, 'calls npm plugin'); | |||
| t.ok(spyPlugin.withArgs('maven').calledOnce, 'calls maven plugin'); | |||
| t.ok(spyPlugin.withArgs('nuget').calledOnce, 'calls nuget plugin'); | |||
| t.ok(spyPlugin.withArgs('paket').calledOnce, 'calls nuget plugin'); | |||
|
|
||
| requests.forEach((req) => { | ||
| t.match(req.url, '/monitor/', 'puts at correct url'); | ||
| t.notOk(req.body.targetFile, "doesn't send the targetFile"); |
There was a problem hiding this comment.
maybe it's time we assert the relevant ones send the targetFile? I am not a fan of removing this because now we have something that will send it rather than change the assertion so we have introduced a blind spot for this plugin
There was a problem hiding this comment.
I agree. I will add plugin specific check.
orsagie
force-pushed
the
feat/add-paket-to-all-projects
branch
from
8026454
to
3cf8799
Compare
orsagie
force-pushed
the
feat/add-paket-to-all-projects
branch
from
3cf8799
to
db34336
Compare
|
🎉 This PR is included in version 1.286.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does this PR do?
Enables paket projets to be autodetected with the --all-projects option set.