feat: add java and maven version to analytics #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
gitphill
reviewed
Jan 30, 2020
src/lib/snyk-test/run-test.ts
Outdated
| analytics.add('javaVersion', javaVersion); | ||
| } | ||
| if (mvnVersion) { | ||
| analytics.add('mvn', mvnVersion); |
There was a problem hiding this comment.
command you run is mvn. can go with maven if you think it's better
miiila
force-pushed
the
feat/report-java-and-mvn-version
branch
from
d7c75d4
to
822f6ba
Compare
gitphill
approved these changes
Jan 30, 2020
miiila
force-pushed
the
feat/report-java-and-mvn-version
branch
from
822f6ba
to
23cbd4c
Compare
|
🎉 This PR is included in version 1.289.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds java and maven version to analytics