refactor: snyk code client improvements #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
force-pushed
the
refactor/snyk-code-client
branch
from
36bd7bd
to
51f88da
Compare
teodora-sandu
force-pushed
the
refactor/snyk-code-client
branch
from
51f88da
to
59bcfa5
Compare
teodora-sandu
changed the title
teodora-sandu
commented
Mar 14, 2024
internal/http/http.go
Outdated
| @@ -60,12 +69,15 @@ var retryErrorCodes = map[int]bool{ | |||
| http.StatusInternalServerError: true, | |||
| } | |||
|
|
|||
| // TODO: mutex lock for configuration? | |||
There was a problem hiding this comment.
The snyk-ls makes sure to not read this value if someone is writing to it, should we do this or leave it to snyk-ls to compute it when giving it to the client?
teodora-sandu
force-pushed
the
refactor/snyk-code-client
branch
from
d8c11f6
to
89dff3a
Compare
|
We think the license checks will continue to fail until this gets merged and I re-import the project. |
teodora-sandu
force-pushed
the
refactor/snyk-code-client
branch
from
6977c30
to
1026162
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains improvements discussed in #10, such as:
CaptureErrortakes in some "options" that tell it whether to send diagnostics for LSP or notgo-application-frameworkinstead ofsnyk-ls- for this the only "configuration" GAF doesn't have is thesnykCodeApiUrl, which instead of moving over I decided to add as another function argument to the functions but I'm happy to discussgolagnci-lintin fixing mode whenmake formatrunsgo-application-frameworksnyk-lsin this repo so that we don't depend onsnyk-ls(eventually the code insnyk-lsshould just disappear, I'm unsure whether to refactor it now or not)